Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-385

AbstractCvsChangeLogCommand create a wrong command for case when startVersion == endVersion

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1
    • 1.1
    • maven-scm-provider-cvs
    • None

    Description

      If we want to get one changelog, then we call ScmManager.changeLog( ScmRepository repository, ScmFileSet fileSet, ScmVersion startVersion, ScmVersion endVersion ) where startVersion = endVersion. Is it true?

      For Subversion it works fine, for example:
      svn log -r3240:3240 http://svn.emforge.org/svn/emforge/maven-scm
      it just returns one revision named 3240

      But the same algorithm does not work with CVS providers - the problem is in that
      AbstractCvsChangeLogCommand uses duplicated colon "::" to specify revisions, but it means that rev1 will be excluded from result:

      -r[revisions] A comma-separated list of revisions to print:
      rev1:rev2 Between rev1 and rev2, including rev1 and rev2.
      rev1::rev2 Between rev1 and rev2, excluding rev1.

      So AbstractCvsChangeLogCommand should use first variant "rev1:rev2" to specify revisions.

      Attachments

        Activity

          People

            siveton Siveton Vincent
            szakusov Sergey Zakusov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: