Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-131

mvn scm:validate does not validate the developerConnection in the pom

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0-beta-3
    • maven-plugin
    • None

    Description

      There are a couple of reasons for this, in ValidateMojo:

      1. The check to see if the scmDeveloperConnection is not null is done on the scmConnection
      2. The @parameter definitions are wrong for both the the scmConnection and scmDeveloperConnection

      The check for scmConnection is never run either because of of the wrong @parameter definitions. But the actual value from the pom is normally checked anyway because the default-value for connectionUrl in AbstractScmMojo is ${pom.scm.connection}. But if you run it like this:
      mvn scm:validate -DconnectionUrl=invalidScmUrl
      the value of pom.scm.connection will not be checked.

      The supplied patch fixes these problems and logs an extra error the tells the user the value of the invalid scm connection url, to help resolve the problem.

      Attachments

        1. SCM-131.patch
          2 kB
          dennislundberg

        Activity

          People

            evenisse Emmanuel Venisse
            dennisl@apache.org Dennis Lundberg
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: