[SANTUARIO-494] Do not include carriage return character (
 or 
) in base64-encoded fields in XML signature

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: Java 2.1.2
• Component/s: Java
• Flags: Patch
• Assignee: Colm O hEigeartaigh
• Reporter: Mikhail Ryagin
• Created: 20/Sep/18 10:11
• Updated: 20/Sep/18 15:14
• Resolved: 20/Sep/18 15:14

Description

In Santuario 2.1.0 there was a switch to use the java.util.Base64 Mime Encoder.

Unfortunately this encoder uses \r\n as end-of-line terminator.

So resulting XML includes escaped \r character, encoded as 
 or  
 for example:

<ds:DigestValue>jFHKh16UIYL+MslahIe06VpUW+Q9uyC/9vvsKiYHalqMwsyN7PChFbeMn0Cg+AAAeJqTgBYdVS+R&#xd;
vpef7TWwJA==</ds:DigestValue>

Apart from being non-pretty it imposes problems in some use cases, for example see https://issues.jboss.org/browse/WFLY-9892

It's better to use \n as end-of-line terminator.

Attaching a patch for this issue.

Issue Links

• relates to: SANTUARIO-482 Don't include newline characters in BASE-64 encoded output if the "org.apache.xml.security.ignoreLineBreaks" system property is set