Uploaded image for project: 'Santuario'
  1. Santuario
  2. SANTUARIO-398

SignedInfo.getCanonicalizedOctetStream() -- getInclusiveNamespaces() ?

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Java 1.5.6
    • Fix Version/s: Java 1.5.8, Java 2.0.2
    • Component/s: Java
    • Labels:
      None

      Description

      [I happened to notice this while reading the code. Offhand it looks to me like a potential bug?]

      In org.apache.xml.security.signature.SignedInfo:

      The signInOctetStream(OutputStream) method checks getInclusiveNamespaces() and uses its value to select between overloaded canonicalizeSubtree(...) methods. All good.

      By contrast, the getCanonicalizedOctetStream() method ignores getInclusiveNamespaces() and always just uses the canonicalizeSubtree(Node) method.

      I'm guessing that getCanonicalizedOctetStream() should use the same logic that signInOctetStream() does, but perhaps I'm missing something.

      Perhaps getCanonicalizedOctetSteam() doesn't actually get used and so this is mostly moot? [I came to this from OpenSAML, which definitely uses signInOctetStream() but, I believe, doesn't use getCanonicalizedOctetSteam()].

        Attachments

          Activity

            People

            • Assignee:
              coheigea Colm O hEigeartaigh
              Reporter:
              maslen Thomas Maslen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: