Santuario
  1. Santuario
  2. SANTUARIO-254

Rework org.apache.xml.security.utils.resolver.ResourceResolver

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Java 1.4.4
    • Fix Version/s: Java 1.5
    • Component/s: Java
    • Security Level: Public (Public issues, viewable by everyone)
    • Labels:
      None

      Description


      For the 1.5 release, we should rework the org.apache.xml.security.utils.resolver.ResourceResolver implementation. There are some thread-safety issues here, as well as some inefficient code.

        Issue Links

          Activity

          Hide
          Colm O hEigeartaigh added a comment -

          A quick note on this fix - as indicated in SANTUARIO-253, there is a (minor) thread-safety issue in ResourceResolver, if a user attempts to register a new ResourceResolver while another thread is in getInstance. This fix solves that problem, at the cost of synchronizing the list in both register and getInstance. I don't believe there will be much of a performance penalty for this. If it proves to be so, it can be reconsidered.

          Colm.

          Show
          Colm O hEigeartaigh added a comment - A quick note on this fix - as indicated in SANTUARIO-253 , there is a (minor) thread-safety issue in ResourceResolver, if a user attempts to register a new ResourceResolver while another thread is in getInstance. This fix solves that problem, at the cost of synchronizing the list in both register and getInstance. I don't believe there will be much of a performance penalty for this. If it proves to be so, it can be reconsidered. Colm.

            People

            • Assignee:
              Colm O hEigeartaigh
              Reporter:
              Colm O hEigeartaigh
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development