Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The CheriyanMehlhornGabow class contains and empty Cheriyan-Mehlhorn/Gabow's algorithm implementation that has to be filled

        Activity

        Hide
        Marco Speranza added a comment -

        Hi Simo, yes you are right.
        the system.out it was a my fault. And I apologize I tought that a little refactoring could be included into the same issue. Next time I'll be more efficent

        Of course I agree your improvemet!

        Show
        Marco Speranza added a comment - Hi Simo, yes you are right. the system.out it was a my fault. And I apologize I tought that a little refactoring could be included into the same issue. Next time I'll be more efficent Of course I agree your improvemet!
        Hide
        Simone Tripodi added a comment -

        Nice to have the issue resolved - less nice the bunch of modifications involved.

        The commit includes both the issue resolution AND a refactoring that is not related to the current issue resolution - please next times split steps you intend to perform ad discuss first.

        Sentences like:

        +        return new KosarajuSharirAlgorithm<V, E, G>( graph ).applyingKosarajuSharir( source );
        
        +        return new CheriyanMehlhornGabowAlgorithm<V, E, G>( graph ).applyingCheriyanMehlhornGabow();
        
        +        return new TarjanAlgorithm<V, E, G>( graph ).applyingTarjan();
        

        why you have to explicitly call the method with the same name? It is a little redundant, check r1297872 out to see if you agree how I propose modifying the signatures.

        As a side note: System.out.println should be removed, discuss on dev@ to add a logger if needed.

        Show
        Simone Tripodi added a comment - Nice to have the issue resolved - less nice the bunch of modifications involved. The commit includes both the issue resolution AND a refactoring that is not related to the current issue resolution - please next times split steps you intend to perform ad discuss first . Sentences like: + return new KosarajuSharirAlgorithm<V, E, G>( graph ).applyingKosarajuSharir( source ); + return new CheriyanMehlhornGabowAlgorithm<V, E, G>( graph ).applyingCheriyanMehlhornGabow(); + return new TarjanAlgorithm<V, E, G>( graph ).applyingTarjan(); why you have to explicitly call the method with the same name? It is a little redundant, check r1297872 out to see if you agree how I propose modifying the signatures. As a side note: System.out.println should be removed, discuss on dev@ to add a logger if needed.
        Hide
        Marco Speranza added a comment -

        Fixed see rev 1297678

        Show
        Marco Speranza added a comment - Fixed see rev 1297678

          People

          • Assignee:
            Marco Speranza
            Reporter:
            Simone Tripodi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development