Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-801

MetricsSnapshotReporter cannot tolerate errors

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.9.1
    • Fix Version/s: None
    • Component/s: metrics
    • Labels:
      None

      Description

      If an error occurs in MetricsSnapshotReporter.run(), it does not get logged anywhere and Executor.scheduleWithFixedDelay() will not reschedule it. The effect is that metrics stop being sent to the metrics topic.

      There should be a try/catch in MetricsSnapshotReporter.run() which logs errors and suppresses them to that the thread still had a chance to run again.

      I ran into this by creating a custom metric (https://github.com/Quantiply/rico/blob/master/core/src/main/java/com/quantiply/samza/metrics/WindowedMapGauge.java) that was accidentally unserializable.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              theduderog Roger Hoover
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: