[SAMZA-258] task.window.ms is inaccurate

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6.0
• Fix Version/s: 0.7.0, 0.8.0
• Assignee: Yan Fang
• Reporter: Chris Riccomini
• Created: 01/May/14 16:14
• Updated: 05/May/14 19:23
• Resolved: 05/May/14 19:23

Description

When running a WindowableTask with a long pause during the window() call, the task.window.ms does not reflect how often window() is called.

If task.window.ms is set to 250ms, and the window() method takes 100ms, you would expect the window() method to be invoked 4 times per second. In fact, it's only invoked 3 times per second:

100ms (window) + 250ms (process) + 100ms (window) + 250ms (process) + 100ms (window) + 250ms (process) = 1050ms

The reason for this is that we reset the window timer AFTER window() returns:

    if (isWindowableTask && windowMs >= 0 && lastWindowMs + windowMs < clock()) {
      task.asInstanceOf[WindowableTask].window(collector, coordinator)
      lastWindowMs = clock()
    }

I think we just need to move lastWindowMs above the window() call.

We should do this for task.commit.ms as well.