Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-2193

Fix unit test failures after rate limiter is a required config

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • test
    • None

    Description

      A recent code merge makes rate limiter as a required config. After that RB is created and before it's merged, some new tests are added without setting or disabling rate limiter.  This cause the unit-test failure. 

       

      > Task :samza-core_2.11:test

      testTableRetryPolicyToConfig FAILED
      java.lang.IllegalArgumentException: Read rate limiter is enabled, there is no read rate limiter configured.
      at com.google.common.base.Preconditions.checkArgument(Preconditions.java:135)
      at org.apache.samza.table.descriptors.RemoteTableDescriptor.validate(RemoteTableDescriptor.java:343)
      at org.apache.samza.table.descriptors.BaseTableDescriptor.toConfig(BaseTableDescriptor.java:75)
      at org.apache.samza.table.descriptors.RemoteTableDescriptor.toConfig(RemoteTableDescriptor.java:270)
      at org.apache.samza.table.remote.descriptors.TestRemoteTableDescriptor.testTableRetryPolicyToConfig(TestRemoteTableDescriptor.java:220)

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              dyin Dengpan Yin
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m