Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-2179

Move the StartpointVisitor abstraction to SystemAdmin interface.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Component/s: None
    • Labels:
      None

      Description

      This patch is comprised of the following changes:

      • Migrates the `StartpointVisitor` abstraction from `SystemConsumer` to `SystemAdmin`. Currently, startpoints are acted upon at the `SystemConsumer` layer. This patch enables resolving startpoint to the offset before starting off the downstream components of SamzaContainer. This provides easier integration path for Startpoint by not mandating that every component of SamzaContainer from OffsetManager, SystemConsumer, SystemConsumers etc to support startpoint semantics and avoids proliferation of Samza public API with startpoints.
      • Moves the `KafkaStartpointVisitor` implementation from `KafkaSystemConsumer` to `KafkaSystemAdmin`. Reverts back the refactor done in `KafkaSystemConsumer` for startpoints.
      • Moved the startpoint tests from `KafkaSystemConsumer` to `KafkaSystemAdmin`.
      • Removes the `StartpointCustom`, which is not required for supporting any type of seek-back for I/O connectors.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                spvenkat Shanthoosh Venkataraman
                Reporter:
                spvenkat Shanthoosh Venkataraman
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 8.5h
                  8.5h