Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1894

Too many redundant definition of system configuration variables

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Quick git grep yields the following:

      yipan-mn1:samza_master yipan$ git grep 'systems\.%s\.samza.factory'
      samza-api/src/main/java/org/apache/samza/operators/descriptors/base/system/SystemDescriptor.java: private static final String FACTORY_CONFIG_KEY = "systems.%s.samza.factory";
      samza-aws/src/test/java/org/apache/samza/system/kinesis/TestKinesisSystemFactory.java: private static final String SYSTEM_FACTORY_REGEX = "systems.%s.samza.factory";
      samza-test/src/main/java/org/apache/samza/test/framework/system/CollectionStreamSystemSpec.java: * <li>"systems.%s.samza.factory" =

      Unknown macro: {@link InMemorySystemFactory}

      </li>
      samza-test/src/main/java/org/apache/samza/test/framework/system/CollectionStreamSystemSpec.java: * <li>"jobs.job-name-and-id.systems.%s.samza.factory" =

      </li>
      samza-test/src/main/java/org/apache/samza/test/framework/system/CollectionStreamSystemSpec.java: private static final String SYSTEM_FACTORY = "systems.%s.samza.factory";
      samza-test/src/test/java/org/apache/samza/test/StandaloneTestUtils.java: private static final String SYSTEM_FACTORY_FORMAT_STRING = "systems.%s.samza.factory";
      samza-test/src/test/java/org/apache/samza/test/processor/TestZkLocalApplicationRunner.java: .put(String.format("systems.%s.samza.factory", systemName), TEST_SYSTEM_FACTORY)
      samza-tools/src/main/java/org/apache/samza/tools/benchmark/AbstractSamzaBench.java: protected static final String CFG_SYSTEM_FACTORY = "systems.%s.samza.factory";

      Most of the configure prefix and keys are already defined in JavaSystemConfig or SystemConfig. We should keep all those configure prefix and key definitions in a single class.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              nickpan47 Yi Pan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: