[SAMZA-1689] Add validations before state transitions in ZkBarrierForVersionUpgrade.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.1
• Assignee: Shanthoosh Venkataraman
• Reporter: Shanthoosh Venkataraman
• Created: 27/Apr/18 08:08
• Updated: 30/Apr/18 16:42
• Resolved: 30/Apr/18 16:42

Description

Problem:
A barrier in zookeeper can be in either DONE or TimedOut state. Existing ZkBarrier implementation doesn't have any state validations before acting upon the barrier events received from zookeeper. This can corrupt barrier states when any of the following occur:

• When a stream processor joins a barrier marked as timed out by the leader of the group.
• When the leader of a group expires a barrier marked as Done. This can happen when a leader plays out a stale events from its in-memory buffer.

This will cause the processors group to go through unnecessary rebalancing phase(worse, corrupt the barrier state).

Changes:

• Introduce a barrier state: NEW which will be the beginning state of a barrier(In existing implementation, barrier is created with empty/null value). Barrier will be marked as Done or TimedOut only if the current barrier state is NEW. 

• Fix the disabled barrier test cases. Add new test cases to validate the changed functionality.
• Improve logging to aid debugging.

 

Issue Links

• links to: GitHub Pull Request #490