Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1416

Better logging around the exception where class loading failed in initializing the SystemFactory for a input/output system

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, there is no log line showing the failure is on which system and which class name failed, when the config variable exists but is an empty string.

          val systemFactories = systemNames.map(systemName => {
            val systemFactoryClassName = config
              .getSystemFactory(systemName)
              .getOrElse(throw new SamzaException("A stream uses system %s, which is missing from the configuration." format systemName))
            (systemName, Util.getObj[SystemFactory](systemFactoryClassName))
          }).toMap
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dnishimura opened a pull request:

          https://github.com/apache/samza/pull/296

          SAMZA-1416 : Better logging around the exception where class loading failed in initializing the SystemFactory for a input/output system

          Also added test coverage for the Util.getObj method.
          @nickpan47 @jmakes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dnishimura/samza samza-1416

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/296.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #296


          commit a0e70da78925c6a3fdf9f51ae3e2e34d132d0dd1
          Author: Daniel Nishimura <dnishimura@gmail.com>
          Date: 2017-09-15T23:07:15Z

          Added better logging to Util.getObj method when exception is thrown.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dnishimura opened a pull request: https://github.com/apache/samza/pull/296 SAMZA-1416 : Better logging around the exception where class loading failed in initializing the SystemFactory for a input/output system Also added test coverage for the Util.getObj method. @nickpan47 @jmakes You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnishimura/samza samza-1416 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #296 commit a0e70da78925c6a3fdf9f51ae3e2e34d132d0dd1 Author: Daniel Nishimura <dnishimura@gmail.com> Date: 2017-09-15T23:07:15Z Added better logging to Util.getObj method when exception is thrown.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/296

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/296
          Hide
          jmakes Jake Maes added a comment -

          Issue resolved by pull request 296
          https://github.com/apache/samza/pull/296

          Show
          jmakes Jake Maes added a comment - Issue resolved by pull request 296 https://github.com/apache/samza/pull/296

            People

            • Assignee:
              Unassigned
              Reporter:
              nickpan47 Yi Pan (Data Infrastructure)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development