Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1412

remove mockito-all from the dependency

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:
      None

      Description

      It is bad practice to use mockito-all because mockito-all include some of dependency's code in the package, which makes the dependency resolving not work expected and causes conflicting issues. For example, mockito-all include the code for hamcrest which may make the dependency point to the class in mockito-all instead of hamcrest-core, if there are any incompatible change in hamcrest, it will cause failure.

      We should remove mockito-all and use mockito-core in the dependency for samza.

        Attachments

          Activity

            People

            • Assignee:
              fredji Fred Ji
              Reporter:
              fredji Fred Ji

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment