Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1396

TestZkLocalApplication tests fails after SAMZA-1385

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.1
    • Component/s: None
    • Labels:
      None

      Description

      SAMZA-1385 fixed the ZkPath collision in Zk between LocalApplicationRunner and ZkJobCoordinator factory.
      1. The context within the zk tree is determined by the used as root when creating zkClient. However, we are using a different mechanism to build `ZkKeyBuilder` in this integration test. Hence, the assertions were failing.
      2. With the intention to support multi-stage applications where each application will have one or more jobs, we introduced app.name and app.id configuration. As of today, we only support single stage jobs, which means that application and job are synonymous. Hence, job.name and job.id in the configuration should be the same as app.name and app.id. This has to be fixed in the integration test.

      In the future, it will be great if the component generating the graph and configs for each stage can also inject the job name and id into the config.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                navina Navina Ramesh
                Reporter:
                navina Navina Ramesh
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: