[SAMZA-1370] Memory leak in CachedStore when using ByteBufferSerde as key serde

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.1
• Assignee: Prateek Maheshwari
• Reporter: Prateek Maheshwari
• Created: 25/Jul/17 21:02
• Updated: 27/Jul/17 22:11
• Resolved: 27/Jul/17 22:11

Description

ByteBufferSerde uses relative bulk get to serialize the provided ByteBuffer which changes its internal position. ByteBuffer's `equals` and `hashCode` depend upon its remaining elements, i.e. on its position. This means that when using ByteBuffers as keys in the CachedStore, flushing cache contents to the underlying store changes their hashCode. Since the hashCode for the key no longer matches the one used when inserting it into the map, the LinkedHashMap cannot correctly evict or remove these entries, leading to a memory leak.

Changing ByteBufferSerde to use absolute get operations or duplicate the provided ByteBuffer before copying should fix this issue.

Issue Links

• links to: GitHub Pull Request #251