Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1347

GroupByContainerIds NPE if containerIds list is null

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.1
    • Component/s: None
    • Labels:
      None

      Description

      Another low-hanging fruit. The null check in group() happens AFTER checking the size of containerIds. These statements should be reordered.

      Also, Since the group(tasks) method always calls the group(tasks, containerIds) method, lets just move all the safety checks there.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jmakes opened a pull request:

          https://github.com/apache/samza/pull/233

          SAMZA-1347: GroupByContainerIds NPE if containerIds list is null

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jmakes/samza samza-1347

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/233.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #233


          commit a25dcf57be0c67507236fb7be8718af6cbe22526
          Author: Jacob Maes <jmaes@linkedin.com>
          Date: 2017-06-26T22:39:15Z

          SAMZA-1347: GroupByContainerIds NPE if containerIds list is null


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jmakes opened a pull request: https://github.com/apache/samza/pull/233 SAMZA-1347 : GroupByContainerIds NPE if containerIds list is null You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmakes/samza samza-1347 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit a25dcf57be0c67507236fb7be8718af6cbe22526 Author: Jacob Maes <jmaes@linkedin.com> Date: 2017-06-26T22:39:15Z SAMZA-1347 : GroupByContainerIds NPE if containerIds list is null
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/233

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/233
          Hide
          jmakes Jake Maes added a comment -

          Issue resolved by pull request 233
          https://github.com/apache/samza/pull/233

          Show
          jmakes Jake Maes added a comment - Issue resolved by pull request 233 https://github.com/apache/samza/pull/233

            People

            • Assignee:
              jmakes Jake Maes
              Reporter:
              jmakes Jake Maes
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development