Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-103

Change string concatenation style

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.6.0
    • Fix Version/s: None
    • Component/s: container, kafka, kv, test, yarn
    • Labels:
      None

      Description

      Most of Samza's logging and output uses the style:

      warn("Some error for %s happened." format (myVar))
      

      This style is actually really problematic because it leads to runtime exceptions in cases where there is an extra %s or there was a %d when it should have been a %s.

      I think we should switch everything over to the standard Java style:

      warn("Some error for " + myVar + " happened.")
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              criccomini Chris Riccomini
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: