Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Labels:
      None

      Description

      1. -s4r parameter is considered but the URI in the "app" znode refers to a local copy of the specified file
      2. without -s4r parameter, when combining application building and uploading (mostly for testing purposes), we need a parameter that indicates where to copy the generated s4r (therefore which URI will be referred to in the "app" znode)

        Issue Links

          Activity

          Hide
          Matthieu Morel added a comment -
          Show
          Matthieu Morel added a comment - Thanks for the review Daniel. I merged into piper branch, commit https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=commit;h=53ed170083da9c81c54d137d8ac68e314557b238
          Hide
          Daniel Gómez Ferro added a comment -

          I agree with the changes, good job. +1

          Show
          Daniel Gómez Ferro added a comment - I agree with the changes, good job. +1
          Hide
          Matthieu Morel added a comment -
          1. I removed the appsDir setting so that files are retrieved and copied in local temporary locations for each S4 node
          2. I added an option -generatedS4R that specifies where to copy the generated S4R

          In addition, I :

          1. refactored the code so that only 1 app can be deployed. This means that there is a single Zookeeper node in /s4/clusterX/app that contains the information about the application for this cluster. Using a Zookeeper directory does not make sense as we want to only deploy a single app per S4 subcluster.
          2. improved the producer/consumer regression test, by deploying a producer app and a consumer app in separate subclusters, and checking effective communication between them
          3. updated cluster resolution from the comm layer is now performed upon S4 node initialization, so that it does not need to be triggered by sending a message, thereby avoiding ERROR org.apache.s4.comm.tcp.TCPEmitter - No ClusterNode exists for partitionId 0 messages

          Patch is available in branch S4-71 ( https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=shortlog;h=refs/heads/S4-71 )

          Show
          Matthieu Morel added a comment - I removed the appsDir setting so that files are retrieved and copied in local temporary locations for each S4 node I added an option -generatedS4R that specifies where to copy the generated S4R In addition, I : refactored the code so that only 1 app can be deployed. This means that there is a single Zookeeper node in /s4/clusterX/app that contains the information about the application for this cluster. Using a Zookeeper directory does not make sense as we want to only deploy a single app per S4 subcluster. improved the producer/consumer regression test, by deploying a producer app and a consumer app in separate subclusters, and checking effective communication between them updated cluster resolution from the comm layer is now performed upon S4 node initialization, so that it does not need to be triggered by sending a message, thereby avoiding ERROR org.apache.s4.comm.tcp.TCPEmitter - No ClusterNode exists for partitionId 0 messages Patch is available in branch S4-71 ( https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=shortlog;h=refs/heads/S4-71 )

            People

            • Assignee:
              Matthieu Morel
              Reporter:
              Matthieu Morel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development