Apache S4
  1. Apache S4
  2. S4-70

s4 node command ignores -zk parameter

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Labels:
      None

      Description

      The system reads the value for the Zookeeper ensembler from the configuration file, by default default.s4.comm.properties from the classpath. Currently the value passed as a parameter in the command line is ignored.

      (Temporary workaround: use a custom comm properties file passed in the -commConfig parameter )

        Activity

        Hide
        Matthieu Morel added a comment -

        merged in piper branch https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=commit;h=3da0170c25a02923d8d51488bcfda54abdf772c4

        The syntax for inline parameters was slightly modified and this is reflected in the corresponding documentation files

        Show
        Matthieu Morel added a comment - merged in piper branch https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=commit;h=3da0170c25a02923d8d51488bcfda54abdf772c4 The syntax for inline parameters was slightly modified and this is reflected in the corresponding documentation files
        Hide
        Daniel Gómez Ferro added a comment -

        Change looks great. I've tried it and both the -zk=HOST and -namedStringParameters={cluster.zk_address=HOST} configuration options work fine.

        Show
        Daniel Gómez Ferro added a comment - Change looks great. I've tried it and both the -zk=HOST and -namedStringParameters={cluster.zk_address=HOST } configuration options work fine.
        Hide
        Matthieu Morel added a comment -

        I uploaded a patch in branch S4-70 . Diff: https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=commitdiff;h=229610681adf96d9a08772777d55cffb71b3620c

        I refactored the loading of guice modules so that :

        • injection of inline parameters (specified through the s4 command) would take precedence over parameters from configuration files
        • injections from custom modules override injection from default core and comm modules
        Show
        Matthieu Morel added a comment - I uploaded a patch in branch S4-70 . Diff: https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=commitdiff;h=229610681adf96d9a08772777d55cffb71b3620c I refactored the loading of guice modules so that : injection of inline parameters (specified through the s4 command) would take precedence over parameters from configuration files injections from custom modules override injection from default core and comm modules

          People

          • Assignee:
            Matthieu Morel
            Reporter:
            Matthieu Morel
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development