Apache S4
  1. Apache S4
  2. S4-66

S4R packaging: improve app class resolution

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6
    • Labels:
      None

      Description

      Currently, when creating an S4R package, the app name added to the manifest is extracted from the source code through a very brittle process ( see line 152 https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=blob;f=subprojects/s4-tools/src/main/resources/templates/build.gradle;h=a1e50e330c4de47928af38a57da17b050c0c62b5;hb=049a6b00b285039f36c2276079bfc2d037ca856b#l152 )

      We should either use a proper Java class to extract that name, or require the name of the app class to be passed as a parameter

        Issue Links

          Activity

          Matthieu Morel created issue -
          Tony Stevenson made changes -
          Field Original Value New Value
          Workflow jira [ 12708781 ] no-reopen-closed, patch-avail [ 12711351 ]
          Matthieu Morel made changes -
          Fix Version/s 0.6 [ 12321702 ]
          Fix Version/s 0.5 [ 12318653 ]
          Matthieu Morel made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Matthieu Morel [ mmorel ]
          Matthieu Morel made changes -
          Link This issue is duplicated by S4-79 [ S4-79 ]
          Aimee Cheng made changes -
          Link This issue is duplicated by S4-118 [ S4-118 ]
          Aimee Cheng made changes -
          Attachment 0001-check-whether-defined-app-class-exists-and-extends-A.patch [ 12571805 ]
          Aimee Cheng made changes -
          Attachment 0001-check-whether-defined-app-class-exists-and-extends-A.patch [ 12571805 ]
          Aimee Cheng made changes -
          Daniel Gómez Ferro made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Matthieu Morel
              Reporter:
              Matthieu Morel
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development