Apache S4
  1. Apache S4
  2. S4-34

Rename s4.comm.netty and constituents to s4.comm.tcp

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Labels:
      None

      Description

      Under s4.comm, we have UDP and Netty. Netty, as such, can be used for a variety of protocols. Hence, using the name netty for tcp might lead to ambiguity. Also, one might want to implement udp using netty in the future.

      We should probably rename it to TCP.

      Please vote for or against this renaming.

        Activity

        Hide
        Matthieu Morel added a comment -

        +1 makes total sense

        upload a git patch to this ticket when you have it, thanks!

        Show
        Matthieu Morel added a comment - +1 makes total sense upload a git patch to this ticket when you have it, thanks!
        Hide
        Karthik Kambatla added a comment -

        Renamed the files. Attached is the patch for the same.

        Show
        Karthik Kambatla added a comment - Renamed the files. Attached is the patch for the same.
        Hide
        Matthieu Morel added a comment -

        +1 looks good to me, I'll apply it to master branch

        2 comments :

        • we should name the patch file S4-34.patch
        • we should mention the jira ticket in the commit log (in this case, it would be: "S4-34 : renamed netty to tcp")
        Show
        Matthieu Morel added a comment - +1 looks good to me, I'll apply it to master branch 2 comments : we should name the patch file S4-34 .patch we should mention the jira ticket in the commit log (in this case, it would be: " S4-34 : renamed netty to tcp")
        Hide
        Matthieu Morel added a comment -

        pushed to master branch, commit 8b642d182862556539e3df4610307fdb20d66c0a

        Show
        Matthieu Morel added a comment - pushed to master branch, commit 8b642d182862556539e3df4610307fdb20d66c0a
        Hide
        Matthieu Morel added a comment -

        commit id 8b642d182862556539e3df4610307fdb20d66c0a

        Show
        Matthieu Morel added a comment - commit id 8b642d182862556539e3df4610307fdb20d66c0a

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development