Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Labels:
      None

      Description

      S4 currently allows file-based configurations - AssignmentFromFile, TopologyFromFile enable it. All configurations should be through zookeeper.

      Removing these configurations includes - (1) cleaning up tests to use zookeeper, and (2) deleting the properties files associated.

      Note: Deleting AssignmentFromFile from the code base also addresses the issue of file-based locking used there in.

        Activity

        Hide
        Matthieu Morel added a comment -

        This is addressed in S4-22

        Show
        Matthieu Morel added a comment - This is addressed in S4-22
        Hide
        Karthik Kambatla added a comment -

        One of my previous patches has addressed most of this; I cleaned up most of the comm tests and other tests also to use zookeeper instead of file-based. I wonder if there is still anything left to be done there.

        Show
        Karthik Kambatla added a comment - One of my previous patches has addressed most of this; I cleaned up most of the comm tests and other tests also to use zookeeper instead of file-based. I wonder if there is still anything left to be done there.
        Hide
        Matthieu Morel added a comment -

        Karthik, can you point out which patch? Anyway this really only matters for when we merge S4-22.

        Show
        Matthieu Morel added a comment - Karthik, can you point out which patch? Anyway this really only matters for when we merge S4-22 .
        Hide
        Karthik Kambatla added a comment -

        Matthieu,

        You have already committed those patches – S4-33 and S4-36 constituted some re-factoring of the code and comm-tests using Zookeeper based configurations.

        I believe we should be able mark this resolved, definitely so after you commit S4-22.

        Thanks much,
        Karthik

        Show
        Karthik Kambatla added a comment - Matthieu, You have already committed those patches – S4-33 and S4-36 constituted some re-factoring of the code and comm-tests using Zookeeper based configurations. I believe we should be able mark this resolved, definitely so after you commit S4-22 . Thanks much, Karthik
        Hide
        Matthieu Morel added a comment -

        Fixed by merging S4-22 (commit 121f33066dc4bf02bd37c618312c97874c6c73c4 )

        Show
        Matthieu Morel added a comment - Fixed by merging S4-22 (commit 121f33066dc4bf02bd37c618312c97874c6c73c4 )

          People

          • Assignee:
            Matthieu Morel
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development