Apache S4
  1. Apache S4
  2. S4-26

standalone application build script fails when the source directory contains more than 1 class

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Labels:
      None

      Description

      This happens in certain cases, depending on the name of the classes.

      For instance, in s4-piper-app, if we add a class named HelloApp2 (that does nothing), the build fails, notably saying:
      16:57:52.033 [QUIET] [system.out] Found app class name: s4app.HelloApp
      16:57:52.039 [QUIET] [system.out] Couldn't find App class in source files...aborting.

        Activity

        Hide
        Matthieu Morel added a comment -

        Fixed in leo's repo https://github.com/leoneu/s4-piper-app

        This was due to the code looping over source files and systematically executing the associated closure, regardless of whether the app class was already found or not. I added a check for that.

        Show
        Matthieu Morel added a comment - Fixed in leo's repo https://github.com/leoneu/s4-piper-app This was due to the code looping over source files and systematically executing the associated closure, regardless of whether the app class was already found or not. I added a check for that.

          People

          • Assignee:
            Matthieu Morel
            Reporter:
            Matthieu Morel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development