Apache S4
  1. Apache S4
  2. S4-120

User singleton scope for injections that should have a unique instance

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6
    • Labels:
      None

      Description

      for instance: emitter, cluster etc...

        Issue Links

          Activity

          Hide
          Matthieu Morel added a comment -

          Patch available in branch S4-120, commit 81f3eba

          Updated modules and classes to prefer @Singleton annotation (serves a documentation purpose as well) except where not applicable (providers.

          Show
          Matthieu Morel added a comment - Patch available in branch S4-120 , commit 81f3eba Updated modules and classes to prefer @Singleton annotation (serves a documentation purpose as well) except where not applicable (providers.
          Hide
          Matthieu Morel added a comment -

          Patch available in branch S4-120 commit 3e4c9e45961e2f6a7b8040dedad53cfd6b448edf
          Includes fix for S4-116

          Show
          Matthieu Morel added a comment - Patch available in branch S4-120 commit 3e4c9e45961e2f6a7b8040dedad53cfd6b448edf Includes fix for S4-116
          Hide
          Matthieu Morel added a comment -

          We'd rather use @Singleton annotation for singleton classes, instead of scoping in the binding statement, because @Singleton also serves as documentation (impl class must be threadsafe)

          I uploaded an update to the patch to address that in commit 1eb5c87

          Show
          Matthieu Morel added a comment - We'd rather use @Singleton annotation for singleton classes, instead of scoping in the binding statement, because @Singleton also serves as documentation (impl class must be threadsafe) I uploaded an update to the patch to address that in commit 1eb5c87
          Hide
          Daniel Gómez Ferro added a comment -

          Thanks for the fix Matthieu!

          Merged in dev commit eb20b959c1a61682f4374f7ae0261cfa858b4ccd

          Show
          Daniel Gómez Ferro added a comment - Thanks for the fix Matthieu! Merged in dev commit eb20b959c1a61682f4374f7ae0261cfa858b4ccd

            People

            • Assignee:
              Matthieu Morel
              Reporter:
              Matthieu Morel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development