Uploaded image for project: 'Apache S4'
  1. Apache S4
  2. S4-105

Incorrect method implementation in org.apache.s4.core.Stream

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6
    • Labels:
      None

      Description

      In class org.apache.s4.core.Stream:

      public Stream<T> setPE(ProcessingElement pe)

      { app.addStream(this); return this; }

      This method implementation is wrong, should add argument pe into targetPEs list, not addStream()

        Activity

        Hide
        mmorel Matthieu Morel added a comment -

        The setPE method was meant to be used internal, and actually not used, that's why we did not detect the issue.

        Patch removes the incorrect method and uses varargs in setPEs as a replacement.

        Available in branch S4-105 commit 6dd0ed0

        Show
        mmorel Matthieu Morel added a comment - The setPE method was meant to be used internal, and actually not used, that's why we did not detect the issue. Patch removes the incorrect method and uses varargs in setPEs as a replacement. Available in branch S4-105 commit 6dd0ed0
        Hide
        dferro Daniel Gómez Ferro added a comment -

        Change looks good and tests pass, please merge!

        Show
        dferro Daniel Gómez Ferro added a comment - Change looks good and tests pass, please merge!
        Hide
        mmorel Matthieu Morel added a comment -

        Merged into dev branch, commit d9e1599

        Show
        mmorel Matthieu Morel added a comment - Merged into dev branch, commit d9e1599

          People

          • Assignee:
            mmorel Matthieu Morel
            Reporter:
            chengxinwu Xinwu Cheng
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1m
              1m
              Remaining:
              Remaining Estimate - 1m
              1m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development