Apache S4
  1. Apache S4
  2. S4-103

Inconsistent Event API on streamName/streamId

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6
    • Labels:

      Description

      In class org.apache.s4.base.Event, the get/set method name for streamName are inconsistent, i.e.

      • getStreamName()
      • setStreamId(String streamName)

      We should keep them consistent, either use streamName or streamId, but not mixed.

        Issue Links

          Activity

          Hide
          Matthieu Morel added a comment -

          Thanks for pointing this out. We should probably use stream Id (not stream name), it's more generic.

          Show
          Matthieu Morel added a comment - Thanks for pointing this out. We should probably use stream Id (not stream name), it's more generic.
          Hide
          Matthieu Morel added a comment -

          Patch available in branch S4-103

          Includes fixes for S4-76 as well

          Show
          Matthieu Morel added a comment - Patch available in branch S4-103 Includes fixes for S4-76 as well
          Hide
          Daniel Gómez Ferro added a comment -

          +1

          Merged on dev commit c8f070a1c800f0117e995821d9841d6a7f4c0bef

          Show
          Daniel Gómez Ferro added a comment - +1 Merged on dev commit c8f070a1c800f0117e995821d9841d6a7f4c0bef

            People

            • Assignee:
              Matthieu Morel
              Reporter:
              Xinwu Cheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development