Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-44

Provide cache for WhereParser on query.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Done
    • Major
    • Resolution: Done
    • None
    • None
    • None

    Description

      Currently, we are building WhereParser on every request and scala parser combinator is notorious for it's slow performance. Actually we don't have to build WhereParser on every request.

      WhereParser is dependent only on Label and where clause string. so I think it is better to provide parser cache with following key. note that Where class do not contain actual data, but expect caller to provide edge to check if given edge should be included or not.

      Key: labelName + where clause string.
      Value: Where class that hold structure for filtering.

      I think this can be important performance improvement and easy to implement.

      Attachments

        Activity

          People

            steamshon Do Yung Yoon
            steamshon Do Yung Yoon
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified