[S2GRAPH-194] Provides a way to remove `service`

• Type: Bug
• Status: In Progress
• Priority: Minor
• Resolution: Unresolved
• Assignee: Daewon Jeong
• Reporter: Daewon Jeong
• Created: 30/Mar/18 02:59
• Updated: 11/Apr/18 08:38

Description

I was looking for a bug while looking at the API to create the `deleteService` function in `graphql`.

The code below is a management API that delete the service.

   
def delete(id: Int)(implicit session: DBSession = AutoSession) = {
    val service = findById(id)
    val serviceName = service.serviceName
    sql"""delete from service_columns where id = ${id}""".execute.apply()
    val cacheKeys = List (s "id = $ id", s "serviceName = $ serviceName")

    cacheKeys.foreach {key =>
      expireCache (key)
      expireCaches (key)
    }
  }

After deleting all of the serviceColumns associated with it, but there is no part to erase the service.

Improvement direction.

1. Check whether the label associated with the service exists
2. Add a friendly error message (change return type from Boolean to Try)