Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-156 0.2.0 Release
  3. S2GRAPH-158

Bug fix on String type InnerVal encoding to use UTF-8 charsetName.

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Done
    • Blocker
    • Resolution: Done
    • 0.2.0
    • 0.2.0
    • None

    Description

      Current master's test failed on following environment and I think it is because of usage of getBytes without specifying encoding on InnerVal class.

      More specifically, I think String's getBytes without encoding cause different result.

       case s: String =>
              val pbr = new SimplePositionedMutableByteRange(s.getBytes.length + 3)
              val len = OrderedBytes.encodeString(pbr, s, order)
              pbr.getBytes().take(len)
      

      I am suggesting change String type InnerVal's serialize/deserialize to use UTF-8 encoding so running environment do not break test cases.

      Attachments

        Issue Links

          Activity

            People

              steamshon Do Yung Yoon
              steamshon Do Yung Yoon
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 72h
                  72h
                  Remaining:
                  Remaining Estimate - 72h
                  72h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified