Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-121

Create `Result` class to hold traverse result edges.

    Details

    • Type: Improvement
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.2.0
    • Labels:

      Description

      Purpose of suggestion.

      GroupBy, OrderBy, Filtering implementation of fetched result edges are spread out multiple parts(Storage, AsynchbaseStorage, PostProcess). It would be much better we can separate post process logic(OrderBy, GroupBy, FilterOut) in `Result` class so any caller simply can benefit single implementation.

      In general, I am suggesting changing PostProcess only call method of Result class, not actually implement logic.

      I was asked if we can provide binary format(not JSON) such as protobuf, thrift, etc and I think it is reasonable demand. While I was tapping out possibility of this, I found out moving post process implementation into `Result` class can make this really easy, I guess we can simply focus on actual `format` not post process logic itself.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                steamshon DOYUNG YOON
                Reporter:
                steamshon DOYUNG YOON
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 168h
                  168h
                  Remaining:
                  Remaining Estimate - 168h
                  168h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified