Apache Roller
  1. Apache Roller
  2. ROL-352

Don't display error message for missing Bookmarks folder.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.8.2
    • Fix Version/s: 1.0RC1
    • Labels:
      None

      Description

      Henri reported "errors" after deleting all his Bookmarks: http://weblogs.flamefew.net/bayard/archives/000893.html

      Perhaps we should not display an error, but just leave it blank?

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        43d 23h 42m 1 Lance Lavandowska 30/Jun/04 15:50
        In Progress In Progress Closed Closed
        9h 51m 1 Lance Lavandowska 01/Jul/04 01:41
        Closed Closed Reopened Reopened
        7s 1 Lance Lavandowska 01/Jul/04 01:41
        Reopened Reopened Closed Closed
        6s 1 Lance Lavandowska 01/Jul/04 01:41
        Glen Mazza made changes -
        Component/s User Interface - General [ 12312757 ]
        Component/s Blogroll (Bookmarks) [ 12312746 ]
        Mark Thomas made changes -
        Workflow jira [ 12458116 ] Default workflow, editable Closed status [ 12623461 ]
        Henri Yandell made changes -
        Project Import Fri Mar 27 23:38:16 PDT 2009 [ 1238222296558 ]
        David Johnson made changes -
        Fix Version/s 0.9.9.5 [ 10130 ]
        Fix Version/s 1.0.0 [ 10008 ]
        Lance Lavandowska made changes -
        Fix Version/s 1.0.0 [ 10008 ]
        Resolution Fixed [ 1 ]
        Status Reopened [ 4 ] Closed [ 6 ]
        Lance Lavandowska made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Lance Lavandowska made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Lance Lavandowska made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Lance Lavandowska made changes -
        Field Original Value New Value
        Assignee David Johnson [ djohnson ] Lance Lavandowska [ lavandowska ]
        Hide
        Lance Lavandowska added a comment -

        I couldn't make up my mind so two conflicting things are happening in bookmark.vm right now:

        in #macro( showBookmarks $folderName $showFolderName $expandingFolder )
        if the folder does not exist it simply prints $folderName (no error)

        in #macro( showFolder $folder $showFolderName $expandingFolder )
        if the folder contains no bookmarks than nothing is displayed (not even the $folder.name)

        These should probably be more consistent, but I couldn't decide which was right: show an empty/non-existent folder or display nothing?

        Show
        Lance Lavandowska added a comment - I couldn't make up my mind so two conflicting things are happening in bookmark.vm right now: in #macro( showBookmarks $folderName $showFolderName $expandingFolder ) if the folder does not exist it simply prints $folderName (no error) in #macro( showFolder $folder $showFolderName $expandingFolder ) if the folder contains no bookmarks than nothing is displayed (not even the $folder.name) These should probably be more consistent, but I couldn't decide which was right: show an empty/non-existent folder or display nothing?
        Lance Lavandowska created issue -

          People

          • Assignee:
            Lance Lavandowska
            Reporter:
            Lance Lavandowska
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development