Apache Roller
  1. Apache Roller
  2. ROL-352

Don't display error message for missing Bookmarks folder.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.8.2
    • Fix Version/s: 1.0RC1
    • Labels:
      None

      Description

      Henri reported "errors" after deleting all his Bookmarks: http://weblogs.flamefew.net/bayard/archives/000893.html

      Perhaps we should not display an error, but just leave it blank?

        Activity

        Hide
        Lance Lavandowska added a comment -

        I couldn't make up my mind so two conflicting things are happening in bookmark.vm right now:

        in #macro( showBookmarks $folderName $showFolderName $expandingFolder )
        if the folder does not exist it simply prints $folderName (no error)

        in #macro( showFolder $folder $showFolderName $expandingFolder )
        if the folder contains no bookmarks than nothing is displayed (not even the $folder.name)

        These should probably be more consistent, but I couldn't decide which was right: show an empty/non-existent folder or display nothing?

        Show
        Lance Lavandowska added a comment - I couldn't make up my mind so two conflicting things are happening in bookmark.vm right now: in #macro( showBookmarks $folderName $showFolderName $expandingFolder ) if the folder does not exist it simply prints $folderName (no error) in #macro( showFolder $folder $showFolderName $expandingFolder ) if the folder contains no bookmarks than nothing is displayed (not even the $folder.name) These should probably be more consistent, but I couldn't decide which was right: show an empty/non-existent folder or display nothing?

          People

          • Assignee:
            Lance Lavandowska
            Reporter:
            Lance Lavandowska
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development