Uploaded image for project: 'Apache Roller'
  1. Apache Roller
  2. ROL-2087

"macro.weblog.searchgoogle" in translated ApplicationResources produces wrong Google URL

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.2
    • Fix Version/s: 5.2.0
    • Component/s: Themes and Macros
    • Labels:
      None

      Description

      ApplicationResources.properties has an entry which is for produce a hyperlink for Google search as follows:

      macro.weblog.searchgoogle=<em>You can also \
      <a href="http://google.com/search?q={0}%20site:{1}/{3}" \
      class="google">try this same search</a> on Google.</em>
      

      The same entry in ApplicationResources_ja.properties:

      macro.weblog.searchgoogle=<em>Google\u3067<a href="http://www.google.co.jp/search?q={0}%20site:{1}/page/{3}" class="google">...</a>...</em>
      

      For example, This produces a hyperlink for the something like following URL:

      http://www.google.co.jp/search?q=someWord%20site:https://roller.example.com/page/myblog

      I believe the part /page/ in translated resources is unnecessary and it makes the search result will contain only the pages under /page/ so I think the part /page/ should be removed.

        Attachments

        1. ROL-2087.patch
          7 kB
          Kohei Nozaki

          Activity

            People

            • Assignee:
              roller_unassigned Roller Unassigned
              Reporter:
              xkylex Kohei Nozaki
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: