[ROL-2066] Comment URLs using https:// not saving properly in Gaurav theme

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 5.1.1
• Fix Version/s: 5.1.2
• Component/s: Themes and Macros
• Assignee: David Johnson
• Reporter: Kohei Nozaki
• Created: 28/Feb/15 04:34
• Updated: 30/Mar/15 12:53
• Resolved: 01/Mar/15 18:25

Description

entry.vm in Gaurav theme has a convenient JavaScript method which named fixURL(). it's binded in the onsubmit event handler in comment form and it prepends http:// to commentor's URL if one has no scheme in the URL. for example it converts the URL which a commentor entered as follows:

www.example.com => http://www.example.com

The code of the method is following:

function fixURL(theForm) {
    if (theForm.url.value != "" &&
        theForm.url.value.indexOf("http://") == -1) { //prepend http://
        theForm.url.value = "http://"+theForm.url.value;
    }
    saveUserInformation(theForm);
}

It works well for most cases, but not for a URL which begins with https:// or some other schemes (e.g. ftp://). it goes wrong with such URL as follows:

https://www.example.com => http://https://www.example.com

I think current implementation of fixURL() which is simply searching "http://" is not enough.