[ROL-2065] Gaurav sometimes displaying empty summary as unresolved "$entry.summary"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.1
• Fix Version/s: 5.1.2
• Component/s: Themes and Macros
• Assignee: David Johnson
• Reporter: Kohei Nozaki
• Created: 28/Feb/15 02:38
• Updated: 30/Mar/15 12:53
• Resolved: 01/Mar/15 18:28

Description

day.vm in Gaurav checks existence of summary in following code:

#if($entry.summary != "")
    <p>$entry.summary</p>
    <a class="btn btn-primary" href="$url.entry($entry.anchor)">Read More <i class="icon-angle-right"></i></a>
#else
    <p>$entry.displayContent</p>
#end

I experienced WEBLOGENTRY.SUMMARY went null accidentally (https://twitter.com/lbtc_xxx/status/549181370908430338). in such case, Gaurav thinks the summary is exist and render it as "$entry.summary". I don't know how summary went null, but the db schema allows null so I guess changing comparison logic to more safer one (use $utils.isNotEmpty() instead) is reasonable.