[ROL-1870] Duplicate bookmarks not showing

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.1
• Fix Version/s: 5.1.0
• Component/s: User Interface - General
• Assignee: Roller Unassigned
• Reporter: Greg Huber
• Created: 30/Jun/10 14:24
• Updated: 25/Aug/14 17:56
• Resolved: 14/Mar/14 01:53

Description

Hello,

Noticed that bookmarks with the same name in the same folder do not show on the ui. The method from WeblogBookmarkFolder

public Set getBookmarks()

{ return this.bookmarks; }

uses a set, but the pojo WeblogBookmark uses this equals/hashcode, ie name and folder. Needs a uniqueness. Only option is to use the id.

public boolean equals(Object other)

{ if (other == this) return true; if (other instanceof WeblogBookmark != true) return false; WeblogBookmark o = (WeblogBookmark)other; return new EqualsBuilder() .append(getName(), o.getName()) .append(getFolder(), o.getFolder()) .isEquals(); }

public int hashCode()

{ return new HashCodeBuilder() .append(getName()) .append(getFolder()) .toHashCode(); }