Apache Roller
  1. Apache Roller
  2. ROL-1776

feed servlet may not call correct template

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 4.0.1, 5.0
    • Component/s: Newsfeeds (RSS & Atom)
    • Labels:
      None
    • Environment:
      Fedora 8

      Description

      In the feed servlet the "templates/feeds/weblog-search-atom.vm" may not be called correclty.

      for the code:
      // determine what template to render with
      boolean siteWide = WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
      if ("entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null)

      { pageId = "templates/feeds/site-search-atom.vm"; }

      else if (siteWide && "entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null)

      { pageId = "templates/feeds/weblog-search-atom.vm"; } else if (siteWide) { pageId = "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; } else { pageId = "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; }

      the siteWide refers to "templates/feeds/weblog-search-atom.vm" where it should refer to "templates/feeds/site-search-atom.vm".

      ie code may need to be:

      // determine what template to render with
      boolean siteWide = WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
      if (siteWide && "entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null) { pageId = "templates/feeds/site-search-atom.vm"; } else if ("entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null) { pageId = "templates/feeds/weblog-search-atom.vm"; }

      else if (siteWide)

      { pageId = "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; }

      else

      { pageId = "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; }

        Activity

        Greg Huber created issue -
        Hide
        David Johnson added a comment -

        Thanks for the fix Greg!

        Committed here:
        http://svn.apache.org/viewvc?rev=735813&view=rev

        Show
        David Johnson added a comment - Thanks for the fix Greg! Committed here: http://svn.apache.org/viewvc?rev=735813&view=rev
        David Johnson made changes -
        Field Original Value New Value
        Assignee Roller Unassigned [ roller_unassigned ] David Johnson [ djohnson ]
        Resolution Fixed [ 1 ]
        Fix Version/s 4.0.1 [ 10290 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.1 [ 10280 ]
        Henri Yandell made changes -
        Project Import Fri Mar 27 23:38:16 PDT 2009 [ 1238222296558 ]
        Mark Thomas made changes -
        Workflow jira [ 12459272 ] Default workflow, editable Closed status [ 12623215 ]
        Hide
        Glen Mazza added a comment -

        Closed issues related to Roller 5.0 release.

        Show
        Glen Mazza added a comment - Closed issues related to Roller 5.0 release.
        Glen Mazza made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Glen Mazza made changes -
        Component/s Newsfeed Aggregation/Syndication [ 12312749 ]
        Component/s Newsfeed Syndication [ 12312750 ]

          People

          • Assignee:
            David Johnson
            Reporter:
            Greg Huber
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development