[ROL-1203] Popup comment pages cached the same as permalink pages

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 2.3
• Component/s: Comments
• Assignee: Roller Unassigned
• Reporter: Richard Jones
• Created: 09/Aug/06 12:25
• Updated: 26/Feb/14 09:24
• Resolved: 26/Feb/14 09:24

Description

classes effected:

org.apache.roller.presentation.WeblogPageRequest.java
org.apache.roller.presentation.filters.WeblogPageCacheFilter.java
org.apache.roller.presentation.filters.IfModifiedWeblogPageCacheFilter.java

The page caching does not take into account the '&popup=true' parameter. This means the following pages will be cached as the same

/roller/page/handle?entry=new_entry_1

and

/roller/page/handle?entry=new_entry_1&popup=true

This causes roller to return the permalink pages when the popup comments form was requested and viceversa.

Resolution:

Add 'private string weblogPopup' to WeblogPageRequest.java and change the 'generateKey()' methods in WeblogPageCacheFilter.java and IfModifiedWeblogPageCacheFilter.java to check for the popup parameter (I can provide the code if requested).