Uploaded image for project: 'Apache Roller'
  1. Apache Roller
  2. ROL-1203

Popup comment pages cached the same as permalink pages

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Comments
    • Labels:
      None

      Description

      classes effected:

      org.apache.roller.presentation.WeblogPageRequest.java
      org.apache.roller.presentation.filters.WeblogPageCacheFilter.java
      org.apache.roller.presentation.filters.IfModifiedWeblogPageCacheFilter.java

      The page caching does not take into account the '&popup=true' parameter. This means the following pages will be cached as the same

      /roller/page/handle?entry=new_entry_1

      and

      /roller/page/handle?entry=new_entry_1&popup=true

      This causes roller to return the permalink pages when the popup comments form was requested and viceversa.

      Resolution:

      Add 'private string weblogPopup' to WeblogPageRequest.java and change the 'generateKey()' methods in WeblogPageCacheFilter.java and IfModifiedWeblogPageCacheFilter.java to check for the popup parameter (I can provide the code if requested).

        Attachments

          Activity

            People

            • Assignee:
              roller_unassigned Roller Unassigned
              Reporter:
              fudgemonday Richard Jones
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: