[ROCKETMQ-98] Risk of unable to release putMessage Lock forever

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0-incubating
• Fix Version/s: 4.1.0-incubating
• Assignee: Jaskey Lam
• Reporter: Jaskey Lam
• Created: 15/Feb/17 02:44
• Updated: 06/Jun/17 03:38
• Resolved: 27/May/17 06:15

Description

In current implemenation, there are two kind of locks dev can choose. If I choose reentrantLock, and lock it then put message, in this time I change the config through admin interface to use spin lock. When trying to unlock, rocketmq will try to unlock the spin lock though actually the reentrantlock is locked, this will cause the reentrantlock not able to release forever and trying to release the wrong spin lock but actully it is not locked!

/**

• Spin util acquired the lock.
  */
  private void lockForPutMessage() {
  if (this.defaultMessageStore.getMessageStoreConfig().isUseReentrantLockWhenPutMessage()) { putMessageNormalLock.lock(); }

  else

  Unknown macro: { boolean flag; do { flag = this.putMessageSpinLock.compareAndSet(true, false); } while (!flag); }

  }

private void releasePutMessageLock() {
if (this.defaultMessageStore.getMessageStoreConfig().isUseReentrantLockWhenPutMessage())

{ putMessageNormalLock.unlock(); }

else

{ this.putMessageSpinLock.compareAndSet(false, true); }

}

Issue Links

• links to: GitHub Pull Request #61