Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-89

WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by java options

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: rocketmq-broker
    • Labels:
      None

      Issue Links

        Activity

        Hide
        lizhanhui Zhanhui Li added a comment -

        When broker starts with configuration file, WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by java options.

        Show
        lizhanhui Zhanhui Li added a comment - When broker starts with configuration file, WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by java options.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user lizhanhui opened a pull request:

        https://github.com/apache/incubator-rocketmq/pull/55

        ROCKETMQ-89 WS_DOMAIN_NAME, SUBGROUP default values overrides custom values

        WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by java options options

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-89

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-rocketmq/pull/55.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #55


        commit 06814a217fcf852cafa42e3307e2573ea02f6d1b
        Author: Zhanhui Li <lizhanhui@apache.org>
        Date: 2017-02-08T08:14:28Z

        Fix ROCKETMQ-89: default value overrides custom value passed by java options


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/55 ROCKETMQ-89 WS_DOMAIN_NAME, SUBGROUP default values overrides custom values WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by java options options You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-89 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 06814a217fcf852cafa42e3307e2573ea02f6d1b Author: Zhanhui Li <lizhanhui@apache.org> Date: 2017-02-08T08:14:28Z Fix ROCKETMQ-89 : default value overrides custom value passed by java options
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        [![Coverage Status](https://coveralls.io/builds/10055548/badge)](https://coveralls.io/builds/10055548)

        Coverage decreased (-0.09%) to 31.229% when pulling *06814a217fcf852cafa42e3307e2573ea02f6d1b on lizhanhui:ROCKETMQ-89* into *e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 [! [Coverage Status] ( https://coveralls.io/builds/10055548/badge)](https://coveralls.io/builds/10055548 ) Coverage decreased (-0.09%) to 31.229% when pulling * 06814a217fcf852cafa42e3307e2573ea02f6d1b on lizhanhui: ROCKETMQ-89 * into * e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user vongosling commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        All checks have failed @lizhanhui

        Show
        githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 All checks have failed @lizhanhui
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        We need to disable reuse forks for the broker module as the newly added unit test requires a more isolated environment to run.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 We need to disable reuse forks for the broker module as the newly added unit test requires a more isolated environment to run.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        > [ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project rocketmq-all: Processing of input or output data failed: Report submission to Coveralls API failed with HTTP status 422: Unprocessable Entity (Couldn't find a repository matching this job.) -> [Help 1]
        [ERROR]
        [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [ERROR]
        [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        Is the service so unreliable?

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 > [ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project rocketmq-all: Processing of input or output data failed: Report submission to Coveralls API failed with HTTP status 422: Unprocessable Entity (Couldn't find a repository matching this job.) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException Is the service so unreliable?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        [![Coverage Status](https://coveralls.io/builds/10071781/badge)](https://coveralls.io/builds/10071781)

        Coverage increased (+0.3%) to 31.581% when pulling *d2a67e4f93af6fe53b3c7637e62139050f7d84ad on lizhanhui:ROCKETMQ-89* into *e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 [! [Coverage Status] ( https://coveralls.io/builds/10071781/badge)](https://coveralls.io/builds/10071781 ) Coverage increased (+0.3%) to 31.581% when pulling * d2a67e4f93af6fe53b3c7637e62139050f7d84ad on lizhanhui: ROCKETMQ-89 * into * e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user zhouxinyu commented on a diff in the pull request:

        https://github.com/apache/incubator-rocketmq/pull/55#discussion_r102898060

        — Diff: broker/pom.xml —
        @@ -66,4 +66,17 @@
        <artifactId>javassist</artifactId>
        </dependency>
        </dependencies>
        +
        + <build>
        + <plugins>
        + <plugin>
        + <artifactId>maven-surefire-plugin</artifactId>
        — End diff –

        It seems that `maven-surefire-plugin` exists in parent pom.xml?

        Show
        githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/55#discussion_r102898060 — Diff: broker/pom.xml — @@ -66,4 +66,17 @@ <artifactId>javassist</artifactId> </dependency> </dependencies> + + <build> + <plugins> + <plugin> + <artifactId>maven-surefire-plugin</artifactId> — End diff – It seems that `maven-surefire-plugin` exists in parent pom.xml?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on a diff in the pull request:

        https://github.com/apache/incubator-rocketmq/pull/55#discussion_r103141482

        — Diff: broker/pom.xml —
        @@ -66,4 +66,17 @@
        <artifactId>javassist</artifactId>
        </dependency>
        </dependencies>
        +
        + <build>
        + <plugins>
        + <plugin>
        + <artifactId>maven-surefire-plugin</artifactId>
        — End diff –

        Yes, the key point here is to override <reuseForks>false</reuseForks>.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/55#discussion_r103141482 — Diff: broker/pom.xml — @@ -66,4 +66,17 @@ <artifactId>javassist</artifactId> </dependency> </dependencies> + + <build> + <plugins> + <plugin> + <artifactId>maven-surefire-plugin</artifactId> — End diff – Yes, the key point here is to override <reuseForks>false</reuseForks>.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        @shroman @zhouxinyu @vongosling Any idea on this issue?

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 @shroman @zhouxinyu @vongosling Any idea on this issue?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        > But I don't quite understand why it has to have so many levels – why not to remove rmqAddressServerDomain and let the user use only rocketmq.namesrv.domain ... ?

        Yes, I am also considering centralizing default values to an external config-default.conf file and expose config.conf for user to override. This is best conducted in a dedicated PR after discussion.
        For this PR, let's fix the logical fault first.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 > But I don't quite understand why it has to have so many levels – why not to remove rmqAddressServerDomain and let the user use only rocketmq.namesrv.domain ... ? Yes, I am also considering centralizing default values to an external config-default.conf file and expose config.conf for user to override. This is best conducted in a dedicated PR after discussion. For this PR, let's fix the logical fault first.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/55

        Merged.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 Merged.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui closed the pull request at:

        https://github.com/apache/incubator-rocketmq/pull/55

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/55

          People

          • Assignee:
            lizhanhui Zhanhui Li
            Reporter:
            lizhanhui Zhanhui Li
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development