[ROCKETMQ-37] Log output information is not accurate

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-incubating
• Assignee: Von Gosling
• Reporter: QianZhenyu
• Created: 09/Jan/17 08:52
• Updated: 23/Jan/17 09:25
• Resolved: 23/Jan/17 09:09

Description

1. in MQClientManager#getAndCreateMQClientInstance line 57
when generate a new key-value pair for client in factoryTable, if there was no mapping for the clientId previously, putIfAbsent will return null, and then output:
"log.warn("Previous MQClientInstance has created for clientId:[{}]", clientId);"
this is wrong, it should output in condition prev != null

2. in SubscriptionGroupManager#deleteSubscriptionGroupConfig line 187
if program execute:
log.warn("delete subscription group failed, subscription group: {} not exist", old);
variable old is always null , it's useless, so it's better to print groupName

Issue Links

• links to: GitHub Pull Request #33