GitHub user dongeforever opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/114

ROCKETMQ-220Add IT test for Filter By SQL 92

https://issues.apache.org/jira/browse/ROCKETMQ-220

@lizhanhui @zhouxinyu

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-220

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114

commit fadfadd1101300bda96f34e1aa86f1cf2f66ef66
Author: dongeforever <dongeforever@apache.org>
Date: 2017-06-07T06:55:02Z

ROCKETMQ-220Add IT test for Filter By SQL 92

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/114

[](https://coveralls.io/builds/11862485)

Coverage decreased (-0.05%) to 38.625% when pulling *fadfadd1101300bda96f34e1aa86f1cf2f66ef66 on dongeforever:ROCKETMQ-220* into *80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop*.

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/114

[](https://coveralls.io/builds/11862485)

Coverage decreased (-0.05%) to 38.625% when pulling *fadfadd1101300bda96f34e1aa86f1cf2f66ef66 on dongeforever:ROCKETMQ-220* into *80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop*.

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/114#discussion_r120556852

— Diff: test/src/main/java/org/apache/rocketmq/test/listener/AbstractListener.java —
@@ -95,6 +95,28 @@ public void stopRecv()

+ public long waitForMessageConsume(int size,
+ int timeoutMills) {
+
+ long curTime = System.currentTimeMillis();
+ while (true) {
+ if (msgBodys.getDataSize() >= size)

+ if (System.currentTimeMillis() - curTime >= timeoutMills) {
+ logger.error(String.format("timeout but [%s] not recv all send messages!",
— End diff –

but [%s] not recv all send messages! --> but [%] did not receive all messages sent!

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/114

+1

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/114

+1, LGTM~

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/114

+1

Commit 703ac00bd271583c0290daad14e45f97f9991f49 in incubator-rocketmq's branch refs/heads/develop from dongeforever
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=703ac00 ]

ROCKETMQ-220 Add IT test for Filter By SQL 92, closes
apache/incubator-rocketmq#114

Github user dongeforever commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/114

@zhouxinyu Thanks

Github user dongeforever closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/114

Commit 703ac00bd271583c0290daad14e45f97f9991f49 in incubator-rocketmq's branch refs/heads/release-4.1.0-incubating from dongeforever
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=703ac00 ]

ROCKETMQ-220 Add IT test for Filter By SQL 92, closes
apache/incubator-rocketmq#114

Commit 605103efd70cac652a0a65a447428c41459ffaa1 in incubator-rocketmq's branch refs/heads/master from dongeforever
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=605103e ]

ROCKETMQ-220 Add IT test for Filter By SQL 92, closes
apache/incubator-rocketmq#114

Commit 605103efd70cac652a0a65a447428c41459ffaa1 in incubator-rocketmq's branch refs/heads/develop from dongeforever
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=605103e ]

ROCKETMQ-220 Add IT test for Filter By SQL 92, closes
apache/incubator-rocketmq#114