Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-20

Default 'consumeFromWhere' is inconsist with example's

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:

      Description

      The example pull consumer has a line code like this:
      consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET)
      This is not necessary for a minimum viable pull consumer.
      If this line is important, then it should be the default value.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dongeforever opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/18

          ROCKETMQ-20 Default 'consumeFromWhere' is inconsist with example's

          The example pull consumer has a line code like this:
          consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET)
          This is not necessary for a minimum viable pull consumer.
          If this line is important, then it should be the default value.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-20

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/18.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #18


          commit c7f4da7cdb1f55e663b5ab284fb40b53c3ce651a
          Author: dongeforever <zhendongliu92@yeah.net>
          Date: 2016-12-27T16:19:05Z

          ROCKETMQ-20 default 'consumeFromWhere' is inconsist with example's


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/18 ROCKETMQ-20 Default 'consumeFromWhere' is inconsist with example's The example pull consumer has a line code like this: consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET) This is not necessary for a minimum viable pull consumer. If this line is important, then it should be the default value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-20 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit c7f4da7cdb1f55e663b5ab284fb40b53c3ce651a Author: dongeforever <zhendongliu92@yeah.net> Date: 2016-12-27T16:19:05Z ROCKETMQ-20 default 'consumeFromWhere' is inconsist with example's
          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/18 https://issues.apache.org/jira/browse/ROCKETMQ-20?filter=-2
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lollipopjin commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/18

          @dongeforever Thanks for you PR, we will add some notes in the example to eliminate confuse.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/18 @dongeforever Thanks for you PR, we will add some notes in the example to eliminate confuse.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/18

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/18

            People

            • Assignee:
              vongosling vongosling
              Reporter:
              zander dongeforever
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development