Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.0-incubating
    • Fix Version/s: 4.1.0-incubating
    • Component/s: rocketmq-remoting
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user lizhanhui opened a pull request:

        https://github.com/apache/incubator-rocketmq/pull/100

        BugFix: ROCKETMQ-191

        As we are setting socket options(sndbuf/recvbuf size) for the future SocketChannel, we need to use childOption for ServerBootstrap class.

        Semantics differences can be found [Netty docs](http://netty.io/wiki/user-guide-for-4.x.html)

        Actually, this is an easy-to-get-confused issue, [Spark had a similar bug too](https://issues.apache.org/jira/browse/SPARK-3502)

        [Vertx has similar settings that we can refer to](https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/net/impl/NetServerBase.java) See the `applyConnectionOptions` method.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-191

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-rocketmq/pull/100.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #100


        commit c80d40abecfe745ff7b17e297d8f04f969f54d8e
        Author: Li Zhanhui <lizhanhui@apache.org>
        Date: 2017-04-28T03:29:24Z

        BugFix: ROCKETMQ-191


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/100 BugFix: ROCKETMQ-191 As we are setting socket options(sndbuf/recvbuf size) for the future SocketChannel, we need to use childOption for ServerBootstrap class. Semantics differences can be found [Netty docs] ( http://netty.io/wiki/user-guide-for-4.x.html ) Actually, this is an easy-to-get-confused issue, [Spark had a similar bug too] ( https://issues.apache.org/jira/browse/SPARK-3502 ) [Vertx has similar settings that we can refer to] ( https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/net/impl/NetServerBase.java ) See the `applyConnectionOptions` method. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-191 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit c80d40abecfe745ff7b17e297d8f04f969f54d8e Author: Li Zhanhui <lizhanhui@apache.org> Date: 2017-04-28T03:29:24Z BugFix: ROCKETMQ-191
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        [![Coverage Status](https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185)

        Coverage decreased (-0.06%) to 37.906% when pulling *c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui:ROCKETMQ-191* into *6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [! [Coverage Status] ( https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185 ) Coverage decreased (-0.06%) to 37.906% when pulling * c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui: ROCKETMQ-191 * into * 6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        [![Coverage Status](https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185)

        Coverage decreased (-0.06%) to 37.906% when pulling *c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui:ROCKETMQ-191* into *6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [! [Coverage Status] ( https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185 ) Coverage decreased (-0.06%) to 37.906% when pulling * c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui: ROCKETMQ-191 * into * 6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        [![Coverage Status](https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185)

        Coverage decreased (-0.06%) to 37.906% when pulling *c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui:ROCKETMQ-191* into *6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [! [Coverage Status] ( https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185 ) Coverage decreased (-0.06%) to 37.906% when pulling * c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui: ROCKETMQ-191 * into * 6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        [![Coverage Status](https://coveralls.io/builds/11287015/badge)](https://coveralls.io/builds/11287015)

        Coverage decreased (-0.09%) to 37.876% when pulling *f77bddd6db14ed3650e33dbc1eb9cca0c0753966 on lizhanhui:ROCKETMQ-191* into *6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [! [Coverage Status] ( https://coveralls.io/builds/11287015/badge)](https://coveralls.io/builds/11287015 ) Coverage decreased (-0.09%) to 37.876% when pulling * f77bddd6db14ed3650e33dbc1eb9cca0c0753966 on lizhanhui: ROCKETMQ-191 * into * 6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user coveralls commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        [![Coverage Status](https://coveralls.io/builds/11287015/badge)](https://coveralls.io/builds/11287015)

        Coverage decreased (-0.09%) to 37.876% when pulling *f77bddd6db14ed3650e33dbc1eb9cca0c0753966 on lizhanhui:ROCKETMQ-191* into *6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop*.

        Show
        githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [! [Coverage Status] ( https://coveralls.io/builds/11287015/badge)](https://coveralls.io/builds/11287015 ) Coverage decreased (-0.09%) to 37.876% when pulling * f77bddd6db14ed3650e33dbc1eb9cca0c0753966 on lizhanhui: ROCKETMQ-191 * into * 6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop *.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user vongosling commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        That's a good polish, but I must point out the 2 point for this optimization. 1. please comply with PR best practice for title as you have corrected before. 2. you can consider the order when many logic and operator together, such as 0&&1&&1(similar 1||0||0, nor 0||0||1), making your logic more effective. For this context, linux platform and netty epoll judge, which one happen to 0 more easily.

        Show
        githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 That's a good polish, but I must point out the 2 point for this optimization. 1. please comply with PR best practice for title as you have corrected before. 2. you can consider the order when many logic and operator together, such as 0&&1&&1(similar 1||0||0, nor 0||0||1), making your logic more effective. For this context, linux platform and netty epoll judge, which one happen to 0 more easily.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        > please comply with PR best practice for title as you have corrected before.
        Yes. Fixed.
        > 2. you can consider the order when many logic and operator together
        What you said is definitely reasonable, but this method is actually a single shot run, rendering optimization sort of unnecessary.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 > please comply with PR best practice for title as you have corrected before. Yes. Fixed. > 2. you can consider the order when many logic and operator together What you said is definitely reasonable, but this method is actually a single shot run, rendering optimization sort of unnecessary.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 80aac138d905561c7a63c8e15fdfe60e958a3032 in incubator-rocketmq's branch refs/heads/develop from Li Zhanhui
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=80aac13 ]

        ROCKETMQ-191 Fix socket options

        Show
        jira-bot ASF subversion and git services added a comment - Commit 80aac138d905561c7a63c8e15fdfe60e958a3032 in incubator-rocketmq's branch refs/heads/develop from Li Zhanhui [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=80aac13 ] ROCKETMQ-191 Fix socket options
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/100

        Merged.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 Merged.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lizhanhui closed the pull request at:

        https://github.com/apache/incubator-rocketmq/pull/100

        Show
        githubbot ASF GitHub Bot added a comment - Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/100

          People

          • Assignee:
            lizhanhui Zhanhui Li
            Reporter:
            lizhanhui Zhanhui Li
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development