Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-187

Measure the code coverage for Integration Tests

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Now we could browse the Unit Tests and IT Tests at
      https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all

      But the IT Test coverage is not correct. It should cover the original sources instead of the the classes in test module.

      As for as I known, the coverage report is generated by matching the collected data(often using java agent) against a set of classes (the module classes compiled from src/main/). you could refer to: http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/

      So we could match the jacoco-it.exec to each module's source classes to get the correct IT coverage report.
      By the way, we'd better exclude the classes in the test module.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dongeforever opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/96

          ROCKETMQ-187Measure the code coverage for Integration Tests, and add sonar-apache profile

          https://issues.apache.org/jira/browse/ROCKETMQ-187

          Now we could browse the Unit Tests and IT Tests at
          https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all
          But the IT Test coverage is not correct. It should cover the original sources instead of the the classes in test module.
          As for as I known, the coverage report is generated by matching the collected data(often using java agent) against a set of classes (the module classes compiled from src/main/). you could refer to: http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/
          So we could match the jacoco-it.exec to each module's source classes to get the correct IT coverage report.
          By the way, we'd better exclude the classes in the test module.

          we may use sonar locally.
          So we'd better use profile to handle different occasions

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dongeforever/incubator-rocketmq IT_POLISH

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/96.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #96


          commit d7a155a4e8d66f20ff4ca4dca55368b593185e9c
          Author: dongeforever <zhendongliu92@yeah.net>
          Date: 2017-04-18T12:42:29Z

          Revise IT code coverage, add sonar-apache profile


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/96 ROCKETMQ-187 Measure the code coverage for Integration Tests, and add sonar-apache profile https://issues.apache.org/jira/browse/ROCKETMQ-187 Now we could browse the Unit Tests and IT Tests at https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all But the IT Test coverage is not correct. It should cover the original sources instead of the the classes in test module. As for as I known, the coverage report is generated by matching the collected data(often using java agent) against a set of classes (the module classes compiled from src/main/). you could refer to: http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/ So we could match the jacoco-it.exec to each module's source classes to get the correct IT coverage report. By the way, we'd better exclude the classes in the test module. we may use sonar locally. So we'd better use profile to handle different occasions You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongeforever/incubator-rocketmq IT_POLISH Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit d7a155a4e8d66f20ff4ca4dca55368b593185e9c Author: dongeforever <zhendongliu92@yeah.net> Date: 2017-04-18T12:42:29Z Revise IT code coverage, add sonar-apache profile
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          @lizhanhui @zhouxinyu @vongosling please have a review

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 @lizhanhui @zhouxinyu @vongosling please have a review
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          [![Coverage Status](https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609)

          Coverage increased (+0.06%) to 34.694% when pulling *d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH* into *42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 [! [Coverage Status] ( https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609 ) Coverage increased (+0.06%) to 34.694% when pulling * d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH * into * 42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          [![Coverage Status](https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609)

          Coverage increased (+0.06%) to 34.694% when pulling *d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH* into *42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 [! [Coverage Status] ( https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609 ) Coverage increased (+0.06%) to 34.694% when pulling * d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH * into * 42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          [![Coverage Status](https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609)

          Coverage increased (+0.06%) to 34.694% when pulling *d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH* into *42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 [! [Coverage Status] ( https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609 ) Coverage increased (+0.06%) to 34.694% when pulling * d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH * into * 42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          The PR is better not to be merged by the original author.
          @lizhanhui @zhouxinyu @shroman please help merge this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 The PR is better not to be merged by the original author. @lizhanhui @zhouxinyu @shroman please help merge this PR.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f5a2ee0a8fecff48064f19ea242c233475e9635f in incubator-rocketmq's branch refs/heads/develop from dongeforever
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=f5a2ee0 ]

          ROCKETMQ-187 Measure the code coverage for Integration Tests, and add sonar-apache profile, closes apache/incubator-rocketmq#96

          Show
          jira-bot ASF subversion and git services added a comment - Commit f5a2ee0a8fecff48064f19ea242c233475e9635f in incubator-rocketmq's branch refs/heads/develop from dongeforever [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=f5a2ee0 ] ROCKETMQ-187 Measure the code coverage for Integration Tests, and add sonar-apache profile, closes apache/incubator-rocketmq#96
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/96

          It's good and looks it's already been merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 It's good and looks it's already been merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/96

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/96

            People

            • Assignee:
              zander dongeforever
              Reporter:
              zander dongeforever
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development