Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Some TC may not pass because of code mistakes.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vsair opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/94

          ROCKETMQ-179 Fix errors of test cases

          1. Add TC of ConsumerManager.
          2. Fix some bugs.
          3. Set file size of commitlog to 256M, instead of 1G(may too big).
          4. Destroy message store in shutdown hook, otherwise could not clear the files generated.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/vsair/incubator-rocketmq ROCKETMQ-179

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/94.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #94


          commit a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099
          Author: xigu.lx <xigu.lx@alibaba-inc.com>
          Date: 2017-04-17T09:25:55Z

          ROCKETMQ-179 Fix errors of test cases
          1. Add TC of ConsumerManager.
          2. Fix some bugs.
          3. Set file size of commitlog to 256M, instead of 1G(may too big).
          4. Destroy message store in shutdown hook, otherwise could not clear the files generated.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vsair opened a pull request: https://github.com/apache/incubator-rocketmq/pull/94 ROCKETMQ-179 Fix errors of test cases 1. Add TC of ConsumerManager. 2. Fix some bugs. 3. Set file size of commitlog to 256M, instead of 1G(may too big). 4. Destroy message store in shutdown hook, otherwise could not clear the files generated. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vsair/incubator-rocketmq ROCKETMQ-179 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 Author: xigu.lx <xigu.lx@alibaba-inc.com> Date: 2017-04-17T09:25:55Z ROCKETMQ-179 Fix errors of test cases 1. Add TC of ConsumerManager. 2. Fix some bugs. 3. Set file size of commitlog to 256M, instead of 1G(may too big). 4. Destroy message store in shutdown hook, otherwise could not clear the files generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/94

          [![Coverage Status](https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290)

          Coverage increased (+0.07%) to 34.693% when pulling *a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair:ROCKETMQ-179* into *7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/94 [! [Coverage Status] ( https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290 ) Coverage increased (+0.07%) to 34.693% when pulling * a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair: ROCKETMQ-179 * into * 7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/94

          [![Coverage Status](https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290)

          Coverage increased (+0.07%) to 34.693% when pulling *a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair:ROCKETMQ-179* into *7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/94 [! [Coverage Status] ( https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290 ) Coverage increased (+0.07%) to 34.693% when pulling * a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair: ROCKETMQ-179 * into * 7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/94

          [![Coverage Status](https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290)

          Coverage increased (+0.07%) to 34.693% when pulling *a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair:ROCKETMQ-179* into *7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/94 [! [Coverage Status] ( https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290 ) Coverage increased (+0.07%) to 34.693% when pulling * a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair: ROCKETMQ-179 * into * 7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/94

          Great~

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/94 Great~
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/94

          Nice. This PR could be merged

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/94 Nice. This PR could be merged
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6a9628b3c3e6835e37baf7b58ad9300364d4d384 in incubator-rocketmq's branch refs/heads/develop from Eric Liu
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=6a9628b ]

          ROCKETMQ-179 Fix errors of IT test cases closes apache/incubator-rocketmq#94

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6a9628b3c3e6835e37baf7b58ad9300364d4d384 in incubator-rocketmq's branch refs/heads/develop from Eric Liu [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=6a9628b ] ROCKETMQ-179 Fix errors of IT test cases closes apache/incubator-rocketmq#94
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vsair closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/94

          Show
          githubbot ASF GitHub Bot added a comment - Github user vsair closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/94
          Hide
          zander dongeforever added a comment -

          Github user vsair closed the pull request at:
          https://github.com/apache/incubator-rocketmq/pull/94

          Show
          zander dongeforever added a comment - Github user vsair closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/94

            People

            • Assignee:
              eric.liu Eric Liu
              Reporter:
              eric.liu Eric Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development