Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-16

Improve the codes of setting topic.json's and subscriptionGroup.json's path

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 4.0.0-incubating
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Take TopicConfigManager#configFilePath() for example:
      public String configFilePath()

      { // return BrokerPathConfigHelper.getTopicConfigPath(this.brokerController.getMessageStoreConfig() // .getStorePathRootDir()); return BrokerPathConfigHelper.getTopicConfigPath(System.getProperty("user.home") + File.separator + "store"); }

      As far as I know, the designers of RMQ want to separate topic.json and subscriptionGroup.json(I call them static config files) from store files to make spreading easily(copy them to a new broker directly). So putting them to another dir is reasonable, but we can do it more graceful.

      At the same time, I add a property named staticConfigFileRootDir in MessageStoreConfig to make their's dir configurable. By default, staticConfigFileRootDir equals storePathRootDir.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Zhang-Ke opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/15

          ROCKETMQ-16 Improve the codes of setting topic.json's and subscriptionGroup.json's path

          ROCKETMQ-16 Improve the codes of setting topic.json's and subscriptionGroup.json's path

          JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-16(url)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-16

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/15.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #15


          commit 7287170a92e52241832a2b5b8930f8f60b9e1fae
          Author: zhangke <zhangke_beijing@qq.com>
          Date: 2016-12-26T10:21:06Z

          ROCKETMQ-16 Improve the codes of setting topic.json's and subscriptionGroup.json's path


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Zhang-Ke opened a pull request: https://github.com/apache/incubator-rocketmq/pull/15 ROCKETMQ-16 Improve the codes of setting topic.json's and subscriptionGroup.json's path ROCKETMQ-16 Improve the codes of setting topic.json's and subscriptionGroup.json's path JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-16 (url) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-16 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 7287170a92e52241832a2b5b8930f8f60b9e1fae Author: zhangke <zhangke_beijing@qq.com> Date: 2016-12-26T10:21:06Z ROCKETMQ-16 Improve the codes of setting topic.json's and subscriptionGroup.json's path
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/15

          It looks good, please @vongosling @lollipopjin review it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/15 It looks good, please @vongosling @lollipopjin review it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/15

          IMO, we can postpone merge this PR here, thanks @Zhang-Ke
          About config module, we would refactor here in the latest release version

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/15 IMO, we can postpone merge this PR here, thanks @Zhang-Ke About config module, we would refactor here in the latest release version
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/15

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/15

            People

            • Assignee:
              vongosling vongosling
              Reporter:
              zhangke Rich Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development