Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-16

Improve the codes of setting topic.json's and subscriptionGroup.json's path

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 4.0.0-incubating
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Take TopicConfigManager#configFilePath() for example:
      public String configFilePath()

      { // return BrokerPathConfigHelper.getTopicConfigPath(this.brokerController.getMessageStoreConfig() // .getStorePathRootDir()); return BrokerPathConfigHelper.getTopicConfigPath(System.getProperty("user.home") + File.separator + "store"); }

      As far as I know, the designers of RMQ want to separate topic.json and subscriptionGroup.json(I call them static config files) from store files to make spreading easily(copy them to a new broker directly). So putting them to another dir is reasonable, but we can do it more graceful.

      At the same time, I add a property named staticConfigFileRootDir in MessageStoreConfig to make their's dir configurable. By default, staticConfigFileRootDir equals storePathRootDir.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vongosling vongosling
                Reporter:
                zhangke Rich Zhang
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: