Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: rocketmq-tools
    • Labels:
      None

      Description

      This is a very minor change. After execute command sh mqadmin, I get the last line info:
      See

      'mqadmin help <command>' for more information on a specific command.[xinwang@hadoop bin]$

      Maybe we can improve this by adding a newline.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vesense opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/83

          ROCKETMQ-154 add a newline after help info

          https://issues.apache.org/jira/browse/ROCKETMQ-154

          This is a very minor change. After execute command sh mqadmin, I get the last line info:
          See `'mqadmin help <command>' for more information on a specific command.[xinwang@hadoop bin]$`

          Maybe we can improve this by adding a newline.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/vesense/incubator-rocketmq ROCKETMQ-154

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/83.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #83


          commit d7cb174903860c41a32178cbcbd91ddf040ac977
          Author: Xin Wang <best.wangxin@163.com>
          Date: 2017-03-24T04:08:02Z

          ROCKETMQ-154 add a newline after help info


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vesense opened a pull request: https://github.com/apache/incubator-rocketmq/pull/83 ROCKETMQ-154 add a newline after help info https://issues.apache.org/jira/browse/ROCKETMQ-154 This is a very minor change. After execute command sh mqadmin, I get the last line info: See `'mqadmin help <command>' for more information on a specific command. [xinwang@hadoop bin] $` Maybe we can improve this by adding a newline. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/incubator-rocketmq ROCKETMQ-154 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit d7cb174903860c41a32178cbcbd91ddf040ac977 Author: Xin Wang <best.wangxin@163.com> Date: 2017-03-24T04:08:02Z ROCKETMQ-154 add a newline after help info
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          [![Coverage Status](https://coveralls.io/builds/10751883/badge)](https://coveralls.io/builds/10751883)

          Coverage increased (+0.3%) to 31.798% when pulling *d7cb174903860c41a32178cbcbd91ddf040ac977 on vesense:ROCKETMQ-154* into *15af63e23b8649537cce56a831c7f965451ce399 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 [! [Coverage Status] ( https://coveralls.io/builds/10751883/badge)](https://coveralls.io/builds/10751883 ) Coverage increased (+0.3%) to 31.798% when pulling * d7cb174903860c41a32178cbcbd91ddf040ac977 on vesense: ROCKETMQ-154 * into * 15af63e23b8649537cce56a831c7f965451ce399 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          [![Coverage Status](https://coveralls.io/builds/10751883/badge)](https://coveralls.io/builds/10751883)

          Coverage increased (+0.3%) to 31.798% when pulling *d7cb174903860c41a32178cbcbd91ddf040ac977 on vesense:ROCKETMQ-154* into *15af63e23b8649537cce56a831c7f965451ce399 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 [! [Coverage Status] ( https://coveralls.io/builds/10751883/badge)](https://coveralls.io/builds/10751883 ) Coverage increased (+0.3%) to 31.798% when pulling * d7cb174903860c41a32178cbcbd91ddf040ac977 on vesense: ROCKETMQ-154 * into * 15af63e23b8649537cce56a831c7f965451ce399 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          [![Coverage Status](https://coveralls.io/builds/10751883/badge)](https://coveralls.io/builds/10751883)

          Coverage increased (+0.3%) to 31.798% when pulling *d7cb174903860c41a32178cbcbd91ddf040ac977 on vesense:ROCKETMQ-154* into *15af63e23b8649537cce56a831c7f965451ce399 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 [! [Coverage Status] ( https://coveralls.io/builds/10751883/badge)](https://coveralls.io/builds/10751883 ) Coverage increased (+0.3%) to 31.798% when pulling * d7cb174903860c41a32178cbcbd91ddf040ac977 on vesense: ROCKETMQ-154 * into * 15af63e23b8649537cce56a831c7f965451ce399 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          LGTM,please @shroman @lizhanhui help to review it~

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 LGTM,please @shroman @lizhanhui help to review it~
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          +1 from me

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 +1 from me
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 08e70ee21061d15d40f3d714d3fda329fc268224 in incubator-rocketmq's branch refs/heads/develop from Xin Wang
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=08e70ee ]

          ROCKETMQ-154 Added a newline after help info. closes #83

          Signed-off-by: shtykh_roman <rshtykh@yahoo.com>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 08e70ee21061d15d40f3d714d3fda329fc268224 in incubator-rocketmq's branch refs/heads/develop from Xin Wang [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=08e70ee ] ROCKETMQ-154 Added a newline after help info. closes #83 Signed-off-by: shtykh_roman <rshtykh@yahoo.com>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          Merged to `develop` branch. Thanks @vesense. Please close this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 Merged to `develop` branch. Thanks @vesense. Please close this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vesense commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/83

          Thanks & Closed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user vesense commented on the issue: https://github.com/apache/incubator-rocketmq/pull/83 Thanks & Closed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vesense closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/83

          Show
          githubbot ASF GitHub Bot added a comment - Github user vesense closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/83

            People

            • Assignee:
              vesense Xin Wang
              Reporter:
              vesense Xin Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development