Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-144

Aggregate distribution specific files to a new module

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: build
    • Labels:
      None

      Description

      When running maven-assembly-plugin, it constantly warns and suggests to use a separate sub-module to aggregate packaging files, which are scattered in the parent projects. Usage of this is exemplified http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user lizhanhui opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/79

          ROCKETMQ-144Aggregate packaging specific files to a new sub-module

          When running maven-assembly-plugin, it constantly warns and suggests to use a separate sub-module to aggregate packaging files, which are scattered in the parent projects. Usage of this is exemplified http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-144

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/79.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #79


          commit 6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1
          Author: Li Zhanhui <lizhanhui@apache.org>
          Date: 2017-03-16T02:21:33Z

          Aggregate packaging specific files to a new sub-module


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/79 ROCKETMQ-144 Aggregate packaging specific files to a new sub-module When running maven-assembly-plugin, it constantly warns and suggests to use a separate sub-module to aggregate packaging files, which are scattered in the parent projects. Usage of this is exemplified http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-144 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit 6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 Author: Li Zhanhui <lizhanhui@apache.org> Date: 2017-03-16T02:21:33Z Aggregate packaging specific files to a new sub-module
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          [![Coverage Status](https://coveralls.io/builds/10618343/badge)](https://coveralls.io/builds/10618343)

          Coverage increased (+0.2%) to 30.982% when pulling *6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 on lizhanhui:ROCKETMQ-144* into *6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [! [Coverage Status] ( https://coveralls.io/builds/10618343/badge)](https://coveralls.io/builds/10618343 ) Coverage increased (+0.2%) to 30.982% when pulling * 6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 on lizhanhui: ROCKETMQ-144 * into * 6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          [![Coverage Status](https://coveralls.io/builds/10618343/badge)](https://coveralls.io/builds/10618343)

          Coverage increased (+0.2%) to 30.982% when pulling *6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 on lizhanhui:ROCKETMQ-144* into *6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [! [Coverage Status] ( https://coveralls.io/builds/10618343/badge)](https://coveralls.io/builds/10618343 ) Coverage increased (+0.2%) to 30.982% when pulling * 6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 on lizhanhui: ROCKETMQ-144 * into * 6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          [![Coverage Status](https://coveralls.io/builds/10618343/badge)](https://coveralls.io/builds/10618343)

          Coverage increased (+0.2%) to 30.982% when pulling *6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 on lizhanhui:ROCKETMQ-144* into *6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [! [Coverage Status] ( https://coveralls.io/builds/10618343/badge)](https://coveralls.io/builds/10618343 ) Coverage increased (+0.2%) to 30.982% when pulling * 6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1 on lizhanhui: ROCKETMQ-144 * into * 6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          LGTM,please @shroman @zhouxinyu help to review it~

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 LGTM,please @shroman @zhouxinyu help to review it~
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          @shroman @zhouxinyu any idea on this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 @shroman @zhouxinyu any idea on this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108323945

          — Diff: distribution/pom.xml —
          @@ -0,0 +1,125 @@
          +<!--
          + ~ Licensed to the Apache Software Foundation (ASF) under one or more
          — End diff –

          Why do we have these `~` in the header?

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108323945 — Diff: distribution/pom.xml — @@ -0,0 +1,125 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more — End diff – Why do we have these `~` in the header?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108325070

          — Diff: distribution/release.xml —
          @@ -1,19 +1,19 @@
          <?xml version="1.0" encoding="UTF-8"?>
          <!--

          • Licensed to the Apache Software Foundation (ASF) under one or more
          • contributor license agreements. See the NOTICE file distributed with
          • this work for additional information regarding copyright ownership.
          • The ASF licenses this file to You under the Apache License, Version 2.0
          • (the "License"); you may not use this file except in compliance with
          • the License. You may obtain a copy of the License at
            -
          • http://www.apache.org/licenses/LICENSE-2.0
            -
          • Unless required by applicable law or agreed to in writing, software
          • distributed under the License is distributed on an "AS IS" BASIS,
          • WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          • See the License for the specific language governing permissions and
          • limitations under the License.
            + ~ Licensed to the Apache Software Foundation (ASF) under one or more
              • End diff –

          Hi,

          The copyright format of `.xml` file is `<Unable to render embedded object: File (-- -->`, instead of `<) not found.-- ~ -->`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108325070 — Diff: distribution/release.xml — @@ -1,19 +1,19 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 - Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + ~ Licensed to the Apache Software Foundation (ASF) under one or more End diff – Hi, The copyright format of `.xml` file is `< Unable to render embedded object: File (-- -->`, instead of `<) not found. -- ~ -->`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344089

          — Diff: distribution/pom.xml —
          @@ -0,0 +1,125 @@
          +<!--
          + ~ Licensed to the Apache Software Foundation (ASF) under one or more
          — End diff –

          It looks like IDEA generates these tilde signs for XML files after I configured the copyright files. Will remove them.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344089 — Diff: distribution/pom.xml — @@ -0,0 +1,125 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more — End diff – It looks like IDEA generates these tilde signs for XML files after I configured the copyright files. Will remove them.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344108

          — Diff: distribution/release.xml —
          @@ -1,19 +1,19 @@
          <?xml version="1.0" encoding="UTF-8"?>
          <!--

          • Licensed to the Apache Software Foundation (ASF) under one or more
          • contributor license agreements. See the NOTICE file distributed with
          • this work for additional information regarding copyright ownership.
          • The ASF licenses this file to You under the Apache License, Version 2.0
          • (the "License"); you may not use this file except in compliance with
          • the License. You may obtain a copy of the License at
            -
          • http://www.apache.org/licenses/LICENSE-2.0
            -
          • Unless required by applicable law or agreed to in writing, software
          • distributed under the License is distributed on an "AS IS" BASIS,
          • WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          • See the License for the specific language governing permissions and
          • limitations under the License.
            + ~ Licensed to the Apache Software Foundation (ASF) under one or more
              • End diff –

          All right.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344108 — Diff: distribution/release.xml — @@ -1,19 +1,19 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 - Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + ~ Licensed to the Apache Software Foundation (ASF) under one or more End diff – All right.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          [![Coverage Status](https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343)

          Coverage increased (+1.0%) to 31.798% when pulling *30c8f13ca19bee9f0e416939a4ee8110b12e36d0 on lizhanhui:ROCKETMQ-144* into *6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [! [Coverage Status] ( https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343 ) Coverage increased (+1.0%) to 31.798% when pulling * 30c8f13ca19bee9f0e416939a4ee8110b12e36d0 on lizhanhui: ROCKETMQ-144 * into * 6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          [![Coverage Status](https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343)

          Coverage increased (+1.0%) to 31.798% when pulling *30c8f13ca19bee9f0e416939a4ee8110b12e36d0 on lizhanhui:ROCKETMQ-144* into *6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [! [Coverage Status] ( https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343 ) Coverage increased (+1.0%) to 31.798% when pulling * 30c8f13ca19bee9f0e416939a4ee8110b12e36d0 on lizhanhui: ROCKETMQ-144 * into * 6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          [![Coverage Status](https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343)

          Coverage increased (+1.0%) to 31.798% when pulling *30c8f13ca19bee9f0e416939a4ee8110b12e36d0 on lizhanhui:ROCKETMQ-144* into *6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [! [Coverage Status] ( https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343 ) Coverage increased (+1.0%) to 31.798% when pulling * 30c8f13ca19bee9f0e416939a4ee8110b12e36d0 on lizhanhui: ROCKETMQ-144 * into * 6b7d206f09b928ea58fb3a62413a053f008b8c1c on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/79

          Merged

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 Merged
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/79

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/79

            People

            • Assignee:
              lizhanhui Zhanhui Li
              Reporter:
              lizhanhui Zhanhui Li
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development