[RIVER-395] Ill-behaved DiscoveryListener can terminate discovery notifier threads

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jtsk_2.1
• Fix Version/s: River_3.0.0
• Component/s: net_jini_discovery
• Assignee: Unassigned
• Reporter: Chris Dolan
• Created: 30/Mar/11 22:04
• Updated: 04/Dec/15 11:51
• Resolved: 04/Dec/15 11:51

Description

(bug detected in Jini 2.1, still present in 2.1.2+ trunk)

If a net.jini.discovery.DiscoveryListener implementation throws an unchecked exception, then the LookupLocatorDiscovery$Notifier thread and/or the LookupDiscovery$Notifier thread will exit prematurely. In practice, this can prevent the JoinManager$DiscMgrListener or ServiceDiscoveryManager$DiscMgrListener callbacks from being invoked, resulting in incomplete state for a registrar.

A soon-to-be attached patch surrounds each listener invocation with a try/catch block.